Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Submit button IDs is submit #1342

Merged
merged 2 commits into from
Sep 8, 2023
Merged

✨ Submit button IDs is submit #1342

merged 2 commits into from
Sep 8, 2023

Conversation

gildub
Copy link
Contributor

@gildub gildub commented Sep 8, 2023

@gildub
Submit button IDs is submit
db681d1 
Signed-off-by: Gilles Dubreuil <gdubreui@redhat.com>
@codecov
Copy link

codecov bot commented Sep 8, 2023 •
edited
Loading

Codecov Report

Patch and project coverage have no change.

Comparison is base (58e8ba5) 42.58% compared to head (ff30b5e) 42.58%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1342   +/-   ##
=======================================
  Coverage   42.58%   42.58%           
=======================================
  Files         136      136           
  Lines        4222     4222           
  Branches     1000     1000           
=======================================
  Hits         1798     1798           
  Misses       2412     2412           
  Partials       12       12
Flag Coverage Δ
client 42.58% <0.00%> (ø)
server ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...s/components/application-form/application-form.tsx 59.60% <0.00%> (ø)
...ntities/components/identity-form/identity-form.tsx 55.87% <ø> (ø)
client/src/app/pages/proxies/proxy-form.tsx 36.29% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

sjd78
sjd78 approved these changes Sep 8, 2023
View reviewed changes
Copy link
Member

@sjd78 sjd78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and with eslint/prettier warning fixes (yay lint-staged)!

@ibolton336 ibolton336 merged commit 2a4eb97 into konveyor:main Sep 8, 2023
6 checks passed
@gildub gildub deleted the button-ids branch September 11, 2023 12:49
This was referenced Nov 22, 2023
Merged
Merged
This was referenced Jan 23, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibolton336 ibolton336 ibolton336 approved these changes

@sjd78 sjd78 sjd78 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gildub @sjd78 @ibolton336